Fixed "ERROR: Using ${var} in strings is deprecated, use {$var} instead" and added logError and logErrorDetails variables on the Shutdown handler #351
Conversation
AntoninoM90
changed the title
|
Why "Tests / Tests PHP 8.1 (pull_request)" is failed? |
|
Why "Tests / Tests PHP 8.1 (pull_request)" is failed? Because of using more than one whitespace between the return type declaration and the variable in a function signature. That may look better, but is against the coding guidelines here… EDITed this post: The stuff I wrote before seems to be against the coding guidelines seems legitimate and isn't what's in question here. |
|
I fixed the php 8.1 test issues but now I'm getting a new error from Coveralls, why? |
|
Because the new changes aren't covered in the unit tests...but I'm not sure if we should do it that way. If the error given to the shutdown handler is an error in the logger itself, we shouldn't give it to the logger. On the other hand, if it wasn't, we should, so I think we should make some try/catch around it. (Only my personal view, not a maintainer.) |
Fixed php error on view user action (src\Application\Actions\User\ViewUserAction.php):
ERROR: Using ${var} in strings is deprecated, use {$var} instead"